This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Segher Boessenkool <segher at kernel dot crashing dot org>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Wed, 2 Aug 2017 17:55:11 +0200
- Subject: Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C2D9FC0587F2
- References: <9a2980f0-01ed-1474-c4a2-f743695d60f8@linux.vnet.ibm.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
> --- gcc/config/rs6000/rs6000.c (revision 250791)
> +++ gcc/config/rs6000/rs6000.c (working copy)
> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
> || rs6000_cpu == PROCESSOR_PPCE5500)
> {
> if (TARGET_ALTIVEC)
> - error ("AltiVec not supported in this target");
> + error ("altivec not supported in this target");
If AltiVec is spelled that way always, then I think we want to keep it
capitalized, but CCing Joseph just to be sure. Or the diagnostics
could be reworded not to have AltiVec first.
> @@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_
> rs6000_isa_flags |= (ISA_3_0_MASKS_SERVER & ~ignore_masks);
> }
> else
> - error ("Power9 target option is incompatible with -mcpu=<xxx> for "
> + error ("power9 target option is incompatible with -mcpu=<xxx> for "
> "<xxx> less than power9");
> }
> else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit)
Similarly, not sure about this one, but isn't it about -mpower9-minmax
being incompatible with -mcpu option not supporting power9 ISA?
The <xxx> and talking about less for strings that aren't necessarily ordered
is just weird.
> @@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_tr
> static bool warned_for_return_big_vectors = false;
> if (!warned_for_return_big_vectors)
> {
> - warning (OPT_Wpsabi, "GCC vector returned by reference: "
> + warning (OPT_Wpsabi, "gcc vector returned by reference: "
> "non-standard ABI extension with no compatibility guarantee");
> warned_for_return_big_vectors = true;
> }
> @@ -12773,7 +12773,7 @@ rs6000_pass_by_reference (cumulative_args_t cum AT
> fprintf (stderr, "function_arg_pass_by_reference: synthetic vector\n");
> if (!warned_for_pass_big_vectors)
> {
> - warning (OPT_Wpsabi, "GCC vector passed by reference: "
> + warning (OPT_Wpsabi, "gcc vector passed by reference: "
> "non-standard ABI extension with no compatibility guarantee");
> warned_for_pass_big_vectors = true;
> }
GCC I think needs to be capitalized. Not sure if talking about GCC vector
is clear, it is talking about the GNU vector extension, perhaps GNU instead?
The rest of the changes look good to me, but I'll defer review to the target
maintainers.
Jakub