This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Improve extraction of changed file in contrib/mklog
- From: Jeff Law <law at redhat dot com>
- To: Yuri Gribov <tetra2005 at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Trevor Saunders <tbsaunde at tbsaunde dot org>
- Date: Wed, 2 Aug 2017 09:38:49 -0600
- Subject: Re: [PATCH] Improve extraction of changed file in contrib/mklog
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CA332C0587DD
- References: <CAJOtW+6B0SZaCkxbNCwHJz52mC_LZahANByEO7r=6cjn5ZpruA@mail.gmail.com> <382416a2-289b-0aaa-5dc0-8f533e7ed593@redhat.com> <CAJOtW+5jRWPwNjqE5m2HHcxa1BMLhDAVfEFXsORvxZ7f-yqWEQ@mail.gmail.com>
On 07/27/2017 08:33 PM, Yuri Gribov wrote:
> On Wed, Jul 26, 2017 at 6:11 PM, Jeff Law <law@redhat.com> wrote:
>> On 07/09/2017 01:03 PM, Yuri Gribov wrote:
>>> Hi,
>>>
>>> Currently mklog will fail to analyze lines like this in patches:
>>> diff -rupN gcc/gcc/testsuite/lib/profopt.exp
>>> gcc-compare-checks/gcc/testsuite/lib/profopt.exp
>>> (it fails with "Error: failed to parse diff for ... and ...").
>>>
>>> This patch fixes it. Ok for trunk?
>>>
>>> -Y
>>>
>>>
>>> mklog-filename-fix-1.patch
>>>
>>>
>>> 2017-07-09 Yury Gribov <tetra2005@gmail.com>
>>>
>>> contrib/
>>> * mklog: Fix extraction of changed file name.
>> One could argue that given general directions python would be a better
>> match than perl, but I don't think it's reasonable to require a rewrite
>> to move forward.
>
> Jeff,
>
> Is this to make script more accessible for hacking by others?
Precisely. In general I think folks here are more adept at python than
perl.
> Otherwise from technical standpoint there probly isn't much
> difference.
Agreed.
>
> I'm fine with rewriting it in Python once I get some time later this month.
Thanks. Saw that fly by, it's in the queue.
jeff