This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC][PATCH] Do refactoring of attribute functions and move them to attribs.[hc].

From: Martin Liška <mliska at suse dot cz>
To: Jeff Law <law at redhat dot com>, Jason Merrill <jason at redhat dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>
Date: Fri, 14 Jul 2017 09:39:58 +0200
Subject: Re: [RFC][PATCH] Do refactoring of attribute functions and move them to attribs.[hc].
Authentication-results: sourceware.org; auth=none
References: <d34360a3-c245-7525-03e7-99a9ba8830e6@suse.cz> <CADzB+2mSLts01iKWZQ-dzZCEjZA-wX96_OHhd-6dmf4PrLVBNQ@mail.gmail.com> <1856059e-e9b1-63d2-717f-e20ec171b329@suse.cz> <alpine.DEB.2.20.1706281605270.25698@digraph.polyomino.org.uk> <CADzB+2nMBvm3vxJ59uCmVJpZEgrf3W6q17Q=DD9uhUbzeTvpDg@mail.gmail.com> <4cf00ee9-4cd7-1806-481f-966611768a15@suse.cz> <CADzB+2my3MZap45Bpb_sH7=j+JsBf2R2+S+7ETDdSW8yhBmDRA@mail.gmail.com> <8a0b2ff0-50f9-771d-fb63-01d17cb06b46@suse.cz> <CADzB+2=o6Wr1jyhk3P2JNYP92B0W6iLcZdgcb8GK3hdMTSjW4Q@mail.gmail.com> <669c960e-f4a8-eae3-efd2-f8c29477a817@suse.cz> <CADzB+2kHe_XW-7jqLNJN5RHgVp2y4TsrK_387yaFb8qSpQY1RA@mail.gmail.com> <e3bb65b3-38f7-08d1-05ab-629fdd9affc3@suse.cz> <7e541554-10a6-9cae-fca0-042900271768@suse.cz> <2039ae2c-a523-1850-4d98-598cbd03b498@redhat.com>

On 07/14/2017 09:23 AM, Jeff Law wrote:
> On 07/13/2017 07:51 AM, Martin Liška wrote:
>> Hi.
>>
>> It's request for comment where I mechanically moved attribute-related function to attribs.[hc].
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Thoughts?
> Seems reasonable.  We don't like to move things around without a good
> reason and I assume you've got something in mind?

Well, I basically identified that attribute-related functions are spread in between
attribs.[ch] and tree.c[ch]. And as the later ones are quite big, the code movement
logical to me.

I'm going to prepare changelog entry for that.

Martin

> 
> jeff
>

References:
- Re: [PATCH v2][RFC] Canonize names of attributes.
  - From: Martin Liška
- Re: [PATCH v2][RFC] Canonize names of attributes.
  - From: Jason Merrill
- Re: [PATCH v2][RFC] Canonize names of attributes.
  - From: Martin Liška
- Re: [PATCH v2][RFC] Canonize names of attributes.
  - From: Jason Merrill
- Re: [PATCH v2][RFC] Canonize names of attributes.
  - From: Martin Liška
- [RFC][PATCH] Do refactoring of attribute functions and move them to attribs.[hc].
  - From: Martin Liška
- Re: [RFC][PATCH] Do refactoring of attribute functions and move them to attribs.[hc].
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]