This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Introduce Statement Frontier Notes and Location Views

On Jul  5, 2017, Alexandre Oliva <aoliva@redhat.com> wrote:

> This patch implements statement frontier notes and location views,
> concepts originally proposed in the GCC Summit back in 2010.  See
> https://people.redhat.com/aoliva/papers/sfn/ for details on the
> original design.

There's a newer blog post about these features that provides further
context and motivation.
https://developers.redhat.com/blog/2017/07/11/statement-frontier-notes-and-location-views/#more-437095


I wonder if it would be useful to break up the patch into smaller
pieces, for purposes of review.  The changes are mostly interdependent,
though it is possible to break it up into major features, say one patch
introducing statement frontier notes, one or more patches fixing new
-fcompare-debug failures, and one patch introducing location views.  The
changes are largely split up like that in the aoliva/SFN branch, though
I don't think it would be appropriate to install these changes as such a
sequence of patches, though, because I don't think it's adequate to have
known regressions, even if temporarily, and the initial SFN patch,
without the subsequent -fcompare-debug fixes, would do just that.

Thoughts?  Advice?

Thanks,

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]