This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add quotes to error messages related to Sanitizers.
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Cc: Jakub Jelinek <jakub at redhat dot com>
- Date: Tue, 11 Jul 2017 13:45:38 -0400
- Subject: Re: [PATCH] Add quotes to error messages related to Sanitizers.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dmalcolm at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B809B3D94F
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B809B3D94F
- References: <f657e237-3fc0-b18f-c3ee-b3406d8c65d9@suse.cz>
On Mon, 2017-07-10 at 11:36 +0200, Martin Liška wrote:
> Hi.
>
> This adds missing quotes to various error messages related to
> AddressSanitizer.
> Patch can bootstrap on ppc64le-redhat-linux and survives regression
> tests.
>
> Ready to be installed?
LGTM, with my "diagnostic messages" maintainer hat on.
Grepping for "-f" within opts.c shows a few other diagnostics there
that could use quotes, but that's not a reason not to go ahead with
this patch.
Thanks
Dave
> Martin
>
> gcc/ChangeLog:
>
> 2017-07-04 Martin Liska <mliska@suse.cz>
>
> * opts.c (finish_options): Add quotes to error messages.
> (parse_sanitizer_options): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2017-07-04 Martin Liska <mliska@suse.cz>
>
> * c-c++-common/ubsan/sanitize-all-1.c: Update scanned pattern.
> * c-c++-common/ubsan/sanitize-recover-1.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-2.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-5.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-7.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-8.c:Likewise.
> * c-c++-common/ubsan/sanitize-recover-9.c:Likewise.
> ---
> gcc/opts.c | 18 +++++++++
> ---------
> gcc/testsuite/c-c++-common/ubsan/sanitize-all-1.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-1.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-2.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-5.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-7.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-8.c | 2 +-
> gcc/testsuite/c-c++-common/ubsan/sanitize-recover-9.c | 2 +-
> 8 files changed, 16 insertions(+), 16 deletions(-)
>
>