This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libdecnumber/bid/bid2dpd_dpd2bid.c: Simplify code
- From: Jeff Law <law at redhat dot com>
- To: Sylvestre Ledru <sylvestre at debian dot org>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 29 Jun 2017 11:35:41 -0600
- Subject: Re: libdecnumber/bid/bid2dpd_dpd2bid.c: Simplify code
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2A006325DAE
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2A006325DAE
- References: <d9aa69ad-aede-6750-698c-91ac0b14bc38@debian.org>
On 05/26/2017 07:34 AM, Sylvestre Ledru wrote:
> Hello,
>
> The attach patch (dup.diff) performs the following changes:
>
> * bid/bid2dpd_dpd2bid.c: Remove identical code for different
> branches (CID 1286836, 1286837, 1286838)
> Remove some useless } else { declaration as we are returning
> Remove some whitespace changes & tab
>
> i attached the word diff to highlight the change.
>
> No functional changes! The identical code has been found by coverity.
>
> Thanks!
>
> S
>
>
>
> dup.diff
>
>
> libdecnumber/ChangeLog:
>
> 2017-05-26 Sylvestre Ledru <sylvestre@debian.org>
>
> * bid/bid2dpd_dpd2bid.c: Remove identical code for different branches (CID 1286836, 1286837, 1286838)
> Remove some useless } else { declaration as we are returning
> Remove some whitespace changes & tab
I fixed up the ChangeLog and committed your change. Thanks,
jeff