This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Sebor <msebor at gmail dot com>
- Cc: Jason Merrill <jason at redhat dot com>, Pedro Alves <palves at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>, hubicka at ucw dot cz
- Date: Thu, 29 Jun 2017 18:15:06 +0200
- Subject: Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)
- Authentication-results: sourceware.org; auth=none
- References: <b729a519-fdef-1ad7-3e33-4b3d451d1a1a@gmail.com> <656ca1db-1082-b1ed-a911-ba7bf48f09c0@redhat.com> <CADzB+2=5ZD4YkENJ65bn-Q-d1RXgn3nGKoFQE+pgja_KPNO1xw@mail.gmail.com> <eb698a52-b142-bec1-e91e-9e85bc2bfa7f@gmail.com>
Hello,
> diff --git a/gcc/hash-table.h b/gcc/hash-table.h
> index 0f7e21a..443d16c 100644
> --- a/gcc/hash-table.h
> +++ b/gcc/hash-table.h
> @@ -803,7 +803,10 @@ hash_table<Descriptor, Allocator>::empty_slow ()
> m_size_prime_index = nindex;
> }
> else
> - memset (entries, 0, size * sizeof (value_type));
> + {
> + for ( ; size; ++entries, --size)
> + *entries = value_type ();
> + }
> m_n_deleted = 0;
> m_n_elements = 0;
> }
This change sends our periodic testers into an infinite loop. It is fault of gcc 4.2 being used
as bootstrap compiler, but perhaps that can be worked around?
Honza