This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Signed builtin support
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Carl Love <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Wed, 28 Jun 2017 16:48:09 -0500
- Subject: Re: [PATCH, rs6000] Signed builtin support
- Authentication-results: sourceware.org; auth=none
- References: <1498664255.7044.4.camel@us.ibm.com>
Hi Carl,
On Wed, Jun 28, 2017 at 08:37:35AM -0700, Carl Love wrote:
> The following patch adds support for the vec_signed, vec_signede,
> vec_signedo and vec_signed2 builtins.
Are those names ABI-dictated?
> * config/rs6000/vsx.md (UNSPEC_VSX_XVCVSPSXWS, UNSPEC_VSX_XVCVSPSXDS,
> UNSPEC_VSX_VSIGNED2): Add UNSPECS
Missing "."
> * gcc.target/powerpc/builtins-3-runnable.c(test_int_result,
> test_unsigned_int_result, test_ll_int_result,
> test_ll_unsigned_int_result): Add result checking functions, add
> debug support.
Space before "(".
> (main): Add builtin function tests, .
Something is missing here?
> Signed-off-by: Carl Love <carll@us.ibm.com>
We don't use those.
> +(define_expand "vunsignede_v2df"
> + /* Little endian word numbering for operand is 3 2 1 0.
> + take (operand[1] operand[1]) and shift left three words
> + 0 1 2 3 0 1 2 3 => 3 0 1 2
> + Words 0 and 2 are now where they need to be for the result. */
Should use tabs for eight leading spaces.
Okay for trunk with those nits fixed. Thanks!
Segher