This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C/C++ PATCH to implement -Wmultistatement-macros (PR c/80116)

On Mon, 2017-06-26 at 11:40 +0200, Marek Polacek wrote:
> On Mon, Jun 19, 2017 at 12:01:06PM +0200, Marek Polacek wrote:
> > On Tue, Jun 13, 2017 at 03:29:32PM +0000, Joseph Myers wrote:
> > > On Tue, 13 Jun 2017, Marek Polacek wrote:
> > > 
> > > > 	* c-parser.c (c_parser_if_body): Set the location of
> > > > the
> > > > 	body of the conditional after parsing all the labels. 
> > > >  Call
> > > > 	warn_for_multistatement_macros.
> > > > 	(c_parser_else_body): Likewise.
> > > > 	(c_parser_switch_statement): Likewise.
> > > > 	(c_parser_while_statement): Likewise.
> > > > 	(c_parser_for_statement): Likewise.
> > > > 	(c_parser_statement): Add a default argument.  Save the
> > > > location
> > > > 	after labels have been parsed.
> > > > 	(c_parser_c99_block_statement): Likewise.
> > > 
> > > The gcc/c/ changes are OK.
> > 
> > Thanks.
> > 
> > David, do you have any more comments on the patch?
> 
> Seems not, so I'll commit the patch today.
> 

Oops; sorry.

I think all I had were those relatively minor comments about the
wording in the description/invoke.texi, but I have no objection to this
going into trunk as-is.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]