Re: [Mechanical Patch ARM/AArch64 1/2] Rename load/store scheduling types to encode data size

[Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>]

On 12/06/17 14:53, James Greenhalgh wrote:
> Hi,
>
> In the AArch64 backend and scheduling models there is some confusion as to
> what the load1/load2 etc. scheduling types refer to. This leads to us using
> load1/load2 in two contexts - for a variety of 32-bit, 64-bit and 128-bit
> loads in AArch32 and 128-bit loads in AArch64. That leads to an undesirable
> confusion in scheduling.
>
> Fixing it is easy, but mechanical and boring. Essentially,
>
>    s/load1/load_4/
>    s/load2/load_8/
>    s/load3/load_12/
>    s/load4/load_16/
>    s/store1/store_4/
>    s/store2/store_8/
>    s/store3/store_12/
>    s/store4/store_16/

So the number now is the number of bytes being loaded?

> Across all sorts of pipeline models, and the two backends.
>
> I have intentionally not modified any of the patterns which now look obviously
> incorrect. I'll be doing a second pass over the AArch64 back-end in patch
> 2/2 which will fix these bugs. The AArch32 back-end looked to me to get this
> correct.
>
> Bootstrapped on AArch64 and ARM without issue - there's no functional
> change here.
>
> OK?

Ok from an arm perspective.

Kyrill

> Thanks,
> James
>
> ---
> gcc/
>
> 2017-06-12  James Greenhalgh  <james.greenhalgh@arm.com>
>
> 	* config/arm/types.md (type): Rename load1/2/3/4 to load_4/8/12/16
> 	and store1/2/3/4 to store_4/8/12/16.
> 	* config/aarch64/aarch64.md: Update for rename.
> 	* config/arm/arm.md: Likewise.: Likewise.
> 	* config/arm/arm.c: Likewise.
> 	* config/arm/thumb1.md: Likewise.
> 	* config/arm/thumb2.md: Likewise.
> 	* config/arm/vfp.md: Likewise.
> 	* config/arm/arm-generic.md: Likewise.
> 	* config/arm/arm1020e.md: Likewise.
> 	* config/arm/arm1026ejs.md: Likewise.
> 	* config/arm/arm1136jfs.md: Likewise.
> 	* config/arm/arm926ejs.md: Likewise.
> 	* config/arm/cortex-a15.md: Likewise.
> 	* config/arm/cortex-a17.md: Likewise.
> 	* config/arm/cortex-a5.md: Likewise.
> 	* config/arm/cortex-a53.md: Likewise.
> 	* config/arm/cortex-a57.md: Likewise.
> 	* config/arm/cortex-a7.md: Likewise.
> 	* config/arm/cortex-a8.md: Likewise.
> 	* config/arm/cortex-a9.md: Likewise.
> 	* config/arm/cortex-m4.md: Likewise.
> 	* config/arm/cortex-m7.md: Likewise.
> 	* config/arm/cortex-r4.md: Likewise.
> 	* config/arm/exynos-m1.md: Likewise.
> 	* config/arm/fa526.md: Likewise.
> 	* config/arm/fa606te.md: Likewise.
> 	* config/arm/fa626te.md: Likewise.
> 	* config/arm/fa726te.md: Likewise.
> 	* config/arm/fmp626.md: Likewise.
> 	* config/arm/iwmmxt.md: Likewise.
> 	* config/arm/ldmstm.md: Likewise.
> 	* config/arm/marvell-pj4.md: Likewise.
> 	* config/arm/xgene1.md: Likewise.
> 	* config/aarch64/thunderx.md: Likewise.
> 	* config/aarch64/thunderx2t99.md: Likewise.