This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbers in GIMPLE.
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Richard Biener <rguenther at suse dot de>, Christophe Lyon <christophe dot lyon at linaro dot org>, Markus Trippelsdorf <markus at trippelsdorf dot de>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Jeff Law <law at redhat dot com>, "GCC Patches" <gcc-patches at gcc dot gnu dot org>, Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, Michael Meissner <meissner at linux dot vnet dot ibm dot com>, nd <nd at arm dot com>
- Date: Fri, 9 Jun 2017 08:14:21 +0000
- Subject: RE: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbers in GIMPLE.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <VI1PR0801MB20313CD2538258D3AAA60F5DFF910@VI1PR0801MB2031.eurprd08.prod.outlook.com> <72535306-7d9c-bc2d-b7a3-06360633cfef@redhat.com> <alpine.DEB.2.20.1701181641540.1980@digraph.polyomino.org.uk> <alpine.DEB.2.20.1701181703580.1980@digraph.polyomino.org.uk> <VI1PR0801MB2031DC35E0B3ADDF40EB5A0AFF7E0@VI1PR0801MB2031.eurprd08.prod.outlook.com> <alpine.DEB.2.20.1701191439001.4255@digraph.polyomino.org.uk> <VI1PR0801MB2031901A2466FC38A4610577FF7E0@VI1PR0801MB2031.eurprd08.prod.outlook.com> <alpine.DEB.2.20.1701191619270.12012@digraph.polyomino.org.uk> <VI1PR0801MB20319A4433E724B869E8423BFF7E0@VI1PR0801MB2031.eurprd08.prod.outlook.com> <alpine.DEB.2.20.1701191819370.12012@digraph.polyomino.org.uk> <20170608103058.GA285@x4> <CAKdteOZ6T8OB-R7HHkUuWgoVrxA-D6rPnH1U3n=9VAU5h4W0eg@mail.gmail.com>,<VI1PR0801MB2031575376F996A705CE73C4FFC90@VI1PR0801MB2031.eurprd08.prod.outlook.com> <VI1PR0801MB2031411786EE5517959DA13DFFC90@VI1PR0801MB2031.eurprd08.prod.outlook.com> <E2E86FA4-2E97-454B-895D-BF405DB01DBC@suse.de>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> For a built-in this is generally valid. For plain isnan it depends on what the
> standard says.
>
> You have to support taking the address of isnan anyway and thus expanding
> to a library call in that case. Why doesn't that not work?
Only because I had put a failsafe in builtins.c with a gcc_unreachable () as I never expect
The built-ins not to be expanded. The ICEs are coming from this call.
>
> Richard.
>
>
> >________________________________________
> >From: Tamar Christina
> >Sent: Thursday, June 8, 2017 1:21:44 PM
> >To: Christophe Lyon; Markus Trippelsdorf
> >Cc: Joseph Myers; Jeff Law; GCC Patches; Wilco Dijkstra;
> >rguenther@suse.de; Michael Meissner; nd
> >Subject: RE: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like
> >numbers in GIMPLE.
> >
> >Thanks, I'm looking at the failure.
> >My final validate seems to have only run the GCC tests.
> >
> >> -----Original Message-----
> >> From: Christophe Lyon [mailto:christophe.lyon@linaro.org]
> >> Sent: 08 June 2017 13:00
> >> To: Markus Trippelsdorf
> >> Cc: Joseph Myers; Tamar Christina; Jeff Law; GCC Patches; Wilco
> >Dijkstra;
> >> rguenther@suse.de; Michael Meissner; nd
> >> Subject: Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like
> >> numbers in GIMPLE.
> >>
> >> On 8 June 2017 at 12:30, Markus Trippelsdorf <markus@trippelsdorf.de>
> >> wrote:
> >> > On 2017.01.19 at 18:20 +0000, Joseph Myers wrote:
> >> >> On Thu, 19 Jan 2017, Tamar Christina wrote:
> >> >>
> >> >> > Hi Joseph,
> >> >> >
> >> >> > I made the requested changes and did a quick pass over the rest
> >of
> >> >> > the fp cases.
> >> >>
> >> >> I've no further comments, but watch out for any related test
> >failures
> >> >> being reported.
> >> >
> >> > g++.dg/opt/pr60849.C started ICEing on both X86_64 and ppc64le.
> >> >
> >>
> >> Same on arm/aarch64, but there are also other regressions on
> >big-endian
> >> configs:
> >> See http://people.linaro.org/~christophe.lyon/cross-
> >> validation/gcc/trunk/249005/report-build-info.html
> >>
> >>
> >> > --
> >> > Markus