This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/6] Port prefetch configuration from aarch32 to aarch64
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Andrew Pinski <apinski at cavium dot com>
- Cc: Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Kyrylo Tkachov <kyrylo dot tkachov at arm dot com>, "Richard Guenther" <richard dot guenther at gmail dot com>, <nd at arm dot com>
- Date: Thu, 8 Jun 2017 14:47:55 +0100
- Subject: Re: [PATCH 4/6] Port prefetch configuration from aarch32 to aarch64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=bestguesspass action=none header.from=arm.com;
- Nodisclaimer: True
- References: <F7C2520D-866C-4293-831D-815BF466DFA2@linaro.org> <4E4A2CDC-89F0-4CA4-804D-9B4442236276@linaro.org> <CA+=Sn1nWwjnvMcYas9NBtnHe+NjAeQCch+RXJ+6sFR+Xyw_HyQ@mail.gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Mon, Jan 30, 2017 at 08:35:00AM -0800, Andrew Pinski wrote:
> On Mon, Jan 30, 2017 at 3:48 AM, Maxim Kuvyrkov
> <maxim.kuvyrkov@linaro.org> wrote:
> > This patch port prefetch configuration from aarch32 backend to aarch64. There is no code-generation change from this patch.
> >
> > This patch also happens to address Kyrill's comment on Andrew's prefetching patch at https://gcc.gnu.org/ml/gcc-patches/2017-01/msg02133.html .
> >
> > This patch also fixes a minor bug in aarch64_override_options_internal(), which used "selected_cpu->tune" instead of "aarch64_tune_params".
>
> I am not a fan of the macro at all.
I'm with Andrew for this. The precedent in the AArch64 port is for
explicitly spelling this out, as we do with the branch costs, approx_modes,
vector costs etc.
I'd rather we went that route than the macro you're using. I don't have
any objections to the rest of your patch.
Thanks,
James