This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR libstdc++/80939 Remove unmeetable constexpr specifiers

From: Jonathan Wakely <jwakely at redhat dot com>
To: Tim Shen <timshen at google dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Tim Song <t dot canens dot cpp at gmail dot com>
Date: Mon, 5 Jun 2017 17:49:47 +0100
Subject: Re: [PATCH] PR libstdc++/80939 Remove unmeetable constexpr specifiers
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A08AF8046E
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A08AF8046E
References: <20170602130734.GA6233@redhat.com> <CAG4ZjN=0A_7LDVudhxin6VP0b5mCO1QuXt9No2Kcu+vvkLS4tg@mail.gmail.com>

On 02/06/17 12:19 -0700, Tim Shen wrote:

On Fri, Jun 2, 2017 at 6:07 AM, Jonathan Wakely wrote:

As the PR points out, we aren't qualifying calls to __ref_cast, and
have 'constexpr' on function templates that can never be usable in
constant expressions.


Apology for the constexpr trolling, but that was not intentional. :)

I'm curious why no tests break. Is it because constexpr in a template
function is a no-op instead of a hard error, when the function
definition is not constexpr?

The patch looks good.


Committed to trunk (I'll backport it to gcc-7-branch some time too).

References:
- [PATCH] PR libstdc++/80939 Remove unmeetable constexpr specifiers
  - From: Jonathan Wakely
- Re: [PATCH] PR libstdc++/80939 Remove unmeetable constexpr specifiers
  - From: Tim Shen via gcc-patches

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]