This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,DWARF,v2] AIX dwarf2out label fix


On 05/18/2017 06:00 AM, David Edelsohn wrote:
This version adds a macro DWARF_INITIAL_LENGTH_SIZE_STR based on
DWARF_OFFSET_SIZE to define the string expression to append to the
label to correct the offset.

Because AIX Assembler inserts the section length, the section label
generated by GCC points to the wrong location and must be adjusted
when referenced in DW_AT_stmt_list.

+  char dl_section_label[MAX_ARTIFICIAL_LABEL_BYTES];

It seems inaccurate to call this variable "label" when it's a label name minus offset. Maybe dl_section_ref?

        if (debug_info_level >= DINFO_LEVEL_TERSE)
          add_AT_lineptr (ctnode->root_die, DW_AT_stmt_list,
                          (!dwarf_split_debug_info
-                         ? debug_line_section_label
+                         ? dl_section_label
                           : debug_skeleton_line_section_label));

Doesn't debug_skeleton_line_section_label need the same offset?

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]