This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Speedup df_insn_refs_verify
- From: Richard Biener <rguenther at suse dot de>
- To: gcc-patches at gcc dot gnu dot org
- Date: Mon, 22 May 2017 09:11:15 +0200 (CEST)
- Subject: [PATCH] Speedup df_insn_refs_verify
- Authentication-results: sourceware.org; auth=none
When not verifying we can actually short-circuit verifying the individual
chains.
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
Richard.
2017-05-22 Richard Biener <rguenther@suse.de>
* df-scan.c (df_insn_refs_verify): Speedup when not verifying.
Index: gcc/df-scan.c
===================================================================
--- gcc/df-scan.c (revision 248263)
+++ gcc/df-scan.c (working copy)
@@ -4103,23 +4103,31 @@ df_insn_refs_verify (struct df_collectio
rtx_insn *insn,
bool abort_if_fail)
{
- bool ret1, ret2, ret3, ret4;
+ bool ret1, ret2, ret3;
unsigned int uid = INSN_UID (insn);
struct df_insn_info *insn_info = DF_INSN_INFO_GET (insn);
df_insn_refs_collect (collection_rec, bb, insn_info);
+ if (! df_mws_verify (&collection_rec->mw_vec, DF_INSN_UID_MWS (uid),
+ abort_if_fail))
+ return false;
+
/* Unfortunately we cannot opt out early if one of these is not
- right because the marks will not get cleared. */
+ right and abort_if_fail is set because the marks will not get cleared. */
ret1 = df_refs_verify (&collection_rec->def_vec, DF_INSN_UID_DEFS (uid),
abort_if_fail);
+ if (!ret1 && !abort_if_fail)
+ return false;
ret2 = df_refs_verify (&collection_rec->use_vec, DF_INSN_UID_USES (uid),
abort_if_fail);
+ if (!ret2 && !abort_if_fail)
+ return false;
ret3 = df_refs_verify (&collection_rec->eq_use_vec, DF_INSN_UID_EQ_USES (uid),
abort_if_fail);
- ret4 = df_mws_verify (&collection_rec->mw_vec, DF_INSN_UID_MWS (uid),
- abort_if_fail);
- return (ret1 && ret2 && ret3 && ret4);
+ if (!ret3 && !abort_if_fail)
+ return false;
+ return (ret1 && ret2 && ret3);
}