This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] objc-runtime-shared-support.c - Identical code for different branches
- From: Jeff Law <law at redhat dot com>
- To: Sylvestre Ledru <sylvestre at debian dot org>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 15 May 2017 19:14:56 -0600
- Subject: Re: [PATCH] objc-runtime-shared-support.c - Identical code for different branches
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 368298553D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 368298553D
- References: <a7194f6a-1b1c-2d50-a79f-e3af1a4cc436@debian.org>
On 05/14/2017 03:58 AM, Sylvestre Ledru wrote:
Hello,
Now that Coverity is up and running, I am trying to fix some errors.
Let's start a trivial one (same code in different branches)
S
0001-2017-05-14-Sylvestre-Ledru-sylvestre-debian.org.patch
From 50248decd02bfac52ad64b64c972750489e2ffa0 Mon Sep 17 00:00:00 2001
From: Sylvestre Ledru<sylvestre@debian.org>
Date: Sun, 14 May 2017 10:55:24 +0200
Subject: [PATCH 1/5] 2017-05-14 Sylvestre Ledru<sylvestre@debian.org>
* objc-runtime-shared-support.c (build_module_descriptor):
Identical code for different branches (since 2012)
CID 1406758
OK. BUt I would rewrite the ChangeLog as
* objc-runtime-shared-support.c (build_module_descriptor):
Remove unnecessary conditional when building instance of
objc_module.
jeff