This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] gcc mainline, add builtin support for vec_bperm(), vec_mule() and vec_mulo and vec_sldw() builtins
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: "Carl E. Love" <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Mon, 15 May 2017 16:53:01 -0500
- Subject: Re: [PATCH, rs6000] gcc mainline, add builtin support for vec_bperm(), vec_mule() and vec_mulo and vec_sldw() builtins
- Authentication-results: sourceware.org; auth=none
- References: <1494878883.4066.334.camel@us.ibm.com>
Hi Carl,
On Mon, May 15, 2017 at 01:08:03PM -0700, Carl E. Love wrote:
> * config/rs6000/rs6000-c: Add support for built-in functions
> * config/rs6000/rs6000-builtin.def: Add definition for SLDW.
> * config/rs6000/altivec.h: Add defintion for vec_sldw.
> * doc/extend.texi: Update the built-in documentation for the
> new built-in functions.
That last line should not be indented.
> * gcc.target/powerpc/builtins-3.c: New vec_mule, vec_mulo test cases.
> * gcc.target/powerpc/builtins-3-p8.c: Add tests for the new Power 8
> built-ins to the test suite file. Note, support for mradds exists
> but no test case exists.
> * gcc.target/powerpc/builtins-3-p9.c: Add tests for the new Power 9
> built-ins to the test suite file.
Same for all lines without * here. And you have two spaces before 9.
Patch itself seems fine, thanks!
Segher