This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] gcc mainline, add builtin support for vec_bperm(), vec_mule() and vec_mulo and vec_sldw() builtins


Hi Carl,

On Mon, May 15, 2017 at 01:08:03PM -0700, Carl E. Love wrote:
>    * config/rs6000/rs6000-c: Add support for built-in functions
>    * config/rs6000/rs6000-builtin.def: Add definition for SLDW.
>    * config/rs6000/altivec.h: Add defintion for vec_sldw.
>    * doc/extend.texi: Update the built-in documentation for the
>      new built-in functions.

That last line should not be indented.

>    * gcc.target/powerpc/builtins-3.c: New vec_mule, vec_mulo test cases.
>    * gcc.target/powerpc/builtins-3-p8.c: Add tests for the new Power 8
>      built-ins to the test suite file.  Note, support for mradds exists
>      but no test case exists.
>    * gcc.target/powerpc/builtins-3-p9.c: Add tests for the new Power  9
>      built-ins to the test suite file.

Same for all lines without * here.  And you have two spaces before 9.

Patch itself seems fine, thanks!


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]