This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't assume __secure_getenv is available
- From: Thomas Schwinge <thomas at codesourcery dot com>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: <fortran at gcc dot gnu dot org>, <gcc-patches at gcc dot gnu dot org>, Jerry DeLisle <jvdelisle at charter dot net>
- Date: Fri, 12 May 2017 09:23:14 +0200
- Subject: Re: [PATCH] Don't assume __secure_getenv is available
- Authentication-results: sourceware.org; auth=none
- References: <20170427125804.GZ1809@tucnak> <1493319051-25795-1-git-send-email-blomqvist.janne@gmail.com>
Hi!
On Thu, 27 Apr 2017 21:50:51 +0300, Janne Blomqvist <blomqvist.janne@gmail.com> wrote:
> [...], retain the support for __secure_getenv but call it only via a
> weak reference.
>
> Regtested on x86_64-pc-linux-gnu, Ok for trunk, 7.x when it reopens,
> 6, 5?
Hmm, how has this been tested? Because:
> --- a/libgfortran/runtime/environ.c
> +++ b/libgfortran/runtime/environ.c
> #ifdef FALLBACK_SECURE_GETENV
> +
> +#if SUPPORTS_WEAKREF && defined(HAVE___SECURE_GETENV)
> +static char* weak_secure_getenv (const char*)
> + __attribute__((__weakref__("__secure_gettime")));
> +#endif
"gettime" vs. "getenv"? ;-)
Grüße
Thomas