This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/3] Remove support for obsolete x86 -malign-foo options
- From: Denys Vlasenko <dvlasenk at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Andrew Pinski <pinskia at gmail dot com>, Bernd Schmidt <bschmidt at redhat dot com>, Sandra Loosemore <sandra at codesourcery dot com>
- Date: Thu, 11 May 2017 14:21:03 +0200
- Subject: Re: [PATCH 1/3] Remove support for obsolete x86 -malign-foo options
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dvlasenk at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 89A0B68A3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 89A0B68A3
- References: <20170418183023.7857-1-dvlasenk@redhat.com> <20170418183023.7857-2-dvlasenk@redhat.com> <CAFULd4ZS=_tQa70+QpYD6LLfEetJv9n2OA8fMBxPHbj62S5nfA@mail.gmail.com>
On 05/06/2017 09:20 AM, Uros Bizjak wrote:
On Tue, Apr 18, 2017 at 8:30 PM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
2017-04-18 Denys Vlasenko <dvlasenk@redhat.com>
* config/i386/i386-common.c (ix86_handle_option): Remove support
for obsolete -malign-loops, -malign-jumps and -malign-functions
options.
* config/i386/i386.opt: Likewise.
...
--- gcc/config/i386/i386.opt (revision 240663)
+++ gcc/config/i386/i386.opt (working copy)
@@ -205,18 +205,6 @@ malign-double
Target Report Mask(ALIGN_DOUBLE) Save
Align some doubles on dword boundary.
-malign-functions=
-Target RejectNegative Joined UInteger
-Function starts are aligned to this power of 2.
-
-malign-jumps=
-Target RejectNegative Joined UInteger
-Jump targets are aligned to this power of 2.
-
-malign-loops=
-Target RejectNegative Joined UInteger
-Loop code aligned to this power of 2.
-
malign-stringops
Target RejectNegative Report InverseMask(NO_ALIGN_STRINGOPS, ALIGN_STRINGOPS) Save
Align destination of the string operations.
Instead of removing the above definitions, please rather redefine them
in a similar way -mcpu in i386.opt is obsoleted
They were already obsoleted sixteen years ago. The warning message
was added:
if (ix86_align_loops_string)
{
- i = atoi (ix86_align_loops_string);
- if (i < 0 || i > MAX_CODE_ALIGN)
- error ("-malign-loops=%d is not between 0 and %d", i, MAX_CODE_ALIGN);
- else
- ix86_align_loops = i;
+ warning ("-malign-loops is obsolete, use -falign-loops");
in the year 2001:
commit a2b35d8705efb23182c3e4b75a5e7727b6ddfc88
Author: geoffk <geoffk@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Fri May 4 06:31:27 2001 +0000
* invoke.texi (i386 Options): Delete references to -malign-jumps,
-malign-loops, -malign-functions.
* i386.c (ix86_align_funcs): Delete.
(ix86_align_loops): Delete.
(ix86_align_jumps): Delete.
(override_options): Mark -malign-* as obsolete. Emulate their
behaviour with the -falign-* options. Default -falign-* from
the processor table.
* i386.h (FUNCTION_BOUNDARY): Define to 16; revert Richard Kenner's
patch of Wed May 2 13:09:36 2001.
(LOOP_ALIGN): Delete.
(LOOP_ALIGN_MAX_SKIP): Delete.
(LABEL_ALIGN_AFTER_BARRIER): Delete.
(LABEL_ALIGN_AFTER_BARRIER_MAX_SKIP): Delete.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@41825 138bc75d-0d04-0410-961f-82ee72b054a4
I would think sixteen years of receiving these warnings should enough
for everyone to switch to the -falign options.