This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, testsuite, PR80606] Remove default_packed lines from i386/avx-vtestp{d,s}*
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 6 May 2017 09:22:43 +0200
- Subject: Re: [patch, testsuite, PR80606] Remove default_packed lines from i386/avx-vtestp{d,s}*
- Authentication-results: sourceware.org; auth=none
- References: <3897685b-a8c5-d226-bfc4-34e3559358f3@mentor.com>
On Sat, May 6, 2017 at 9:12 AM, Tom de Vries <Tom_deVries@mentor.com> wrote:
> Hi,
>
> The test-cases i386/avx-vtestp{d,s}* contain lines guarded with target
> default_packed, using absolute line numbers 150 and 164. The absolute line
> numbers intend to refer to the position of the packed attribute in unions
> ieee754_float and ieee754_double in m128-check.h, but they do not match the
> actual lines.
>
> The default_packed lines were introduced for netware support in 2009, but
> netware support was removed in 2011.
>
> The line numbers changes from:
> ...
> 149 unsigned sign : 1;
> 150 } bits __attribute__((packed));
> 151 };
> --
> 163 unsigned sign : 1;
> 164 } bits __attribute__((packed));
> 165 };
> ...
>
> to:
> ...
> 149 unsigned long frac : 23;
> 150 unsigned exp : 8;
> 151 unsigned sign : 1;
> --
> 163 unsigned long frac0 : 20;
> 164 unsigned exp : 11;
> 165 unsigned sign : 1;
> ...
> in Jan 2014 in r207150.
>
> Apparently nobody noticed when the line numbers changed, so they are
> effectively unmaintained.
>
> This patch removes the unmaintained lines.
>
> Tested on x86_64.
>
> OK for trunk?
OK.
Thanks,
Uros.