This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] x86: vpermil2p{s,d} have no commutative operands
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Mon, 1 May 2017 11:09:07 +0200
- Subject: Re: [PATCH] x86: vpermil2p{s,d} have no commutative operands
- Authentication-results: sourceware.org; auth=none
- References: <5903730602000078001552F0@prv-mh.provo.novell.com> <5903730602000078001552F0@prv-mh.provo.novell.com>
On Fri, Apr 28, 2017 at 4:51 PM, Jan Beulich <JBeulich@suse.com> wrote:
> While either of the last two operands can be in memory, they can't be
> swapped.
>
> gcc/
> 2017-04-28 Jan Beulich <jbeulich@suse.com>
>
> * config/i386/sse.md (xop_vpermil2<mode>3): Use alternatives.
Please write a more descriptive ChangeLog entry, e.g. "Do not allow
operand swapping, add (x,x,m,x,n) alternative.
OK with above change for mainline and release branches.
Thanks,
Uros.
> --- a/gcc/config/i386/sse.md
> +++ b/gcc/config/i386/sse.md
> @@ -17092,12 +17092,12 @@
> (set_attr "mode" "TI")])
>
> (define_insn "xop_vpermil2<mode>3"
> - [(set (match_operand:VF_128_256 0 "register_operand" "=x")
> + [(set (match_operand:VF_128_256 0 "register_operand" "=x,x")
> (unspec:VF_128_256
> - [(match_operand:VF_128_256 1 "register_operand" "x")
> - (match_operand:VF_128_256 2 "nonimmediate_operand" "%x")
> - (match_operand:<sseintvecmode> 3 "nonimmediate_operand" "xm")
> - (match_operand:SI 4 "const_0_to_3_operand" "n")]
> + [(match_operand:VF_128_256 1 "register_operand" "x,x")
> + (match_operand:VF_128_256 2 "nonimmediate_operand" "x,m")
> + (match_operand:<sseintvecmode> 3 "nonimmediate_operand" "xm,x")
> + (match_operand:SI 4 "const_0_to_3_operand" "n,n")]
> UNSPEC_VPERMIL2))]
> "TARGET_XOP"
> "vpermil2<ssemodesuffix>\t{%4, %3, %2, %1, %0|%0, %1, %2, %3, %4}"
>
>
>