This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [CHKP] Fix for PR79988
- From: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: Alexander Ivchenko <aivchenk at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 20 Apr 2017 20:29:31 +0300
- Subject: Re: [CHKP] Fix for PR79988
- Authentication-results: sourceware.org; auth=none
- References: <CACysShih6q6rzeUZ58_e-iDzXF-jC8=2u8kvHm-+tnkJSDJEew@mail.gmail.com> <yddshl3xnzx.fsf@CeBiTec.Uni-Bielefeld.DE>
Hi,
Please put comment to code explaining why you don't use
gimple_call_builtin_p to avoid similar issues in the future.
Also please follow Rainer's comments.
OK with these fixes.
Thanks,
Ilya
2017-04-20 15:27 GMT+03:00 Rainer Orth <ro@cebitec.uni-bielefeld.de>:
> Hi Alexander,
>
> just a couple of nits:
>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/i386/mpx/PR79988.c: New test.
>
> We usually don't use capital PR in testcase names. Please use pr79988.c
> instead, matching the other files there.
>
> Also, both ChangeLog entries should include a PR reference like so:
>
> PR middle-end/79988
> * gcc.target/i386/mpx/pr79988.c: New test.
>
> so the commit messages are automatically forwarded to bugzilla.
>
>> gcc/ChangeLog:
>>
>> * tree-chkp.c (chkp_gimple_call_builtin_p):
>> Remove gimple_call_builtin_p call to avoid the call
>> of gimple_builtin_call_types_compatible_p. this will
>> strip the checks for address spaces, which can be skipped
>> without loosing the functionality
>
> ChangeLog entries only describe *what* changed, not *why*.
>
> Thanks.
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University