Re: [PATCH, GCC, stage4] Fix type for .init_array.* and .fini_array.* sections

[Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>]

Hi Kyrill,

On 19/04/17 10:56, Kyrill Tkachov wrote:
> Hi Thomas,
>
> On 11/04/17 18:35, Thomas Preudhomme wrote:
> > Hi,
> >
> > Several tests started failing for ARM targets (eg. gcc.dg/initpri1.c)
> > after change 6f9dbcd42f2cf034a9a21f46842c08d2e88449db in binutils. This
> > is because the non-default priority init_array and fini_array sections
> > are not created with NOTYPE flag as is the case for default priority
> > init_array and fini_array sections (see default_section_type_flags in
> > varasm.c for instance). This patch fixes the issue.
> >
> > ChangeLog entry is as follows:
> >
> > *** gcc/ChangeLog ***
> >
> > 2017-04-11  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> >     * config/arm/arm.c (arm_elf_asm_cdtor): Create non-default
> >     priority .init_array and .fini_array section with SECTION_NOTYPE
> >     flag.
> >
> > Testing: with this patch test gcc.dg/initpri1.c succeeds but fails
> > without.
> >
> > Is this ok for stage4?
>
> This is ok if a bootstrap and test run on arm-none-linux-gnueabihf shows no
> problems.

No issue found, hence committed. Thanks.

Best regards,

Thomas