This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: port contrib/download_prerequisites script to macOS

From: Jeff Law <law at redhat dot com>
To: Damian Rouson <damian at sourceryinstitute dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>
Cc: Jerry DeLisle <jvdelisle at charter dot net>
Date: Wed, 12 Apr 2017 16:03:16 -0600
Subject: Re: port contrib/download_prerequisites script to macOS
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 780FD80F7C
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 780FD80F7C
References: <etPan.58e44420.2d1bb7c0.14e0e@sourceryinstitute.org>

On 04/04/2017 07:10 PM, Damian Rouson wrote:

All,

The attached patch modifies the contrib/download_prerequisites script to work on macOS.
The revised script detects the operating system and adjusts the shasum and md5 commands
to their expected name and arguments on macOS.  The revised script also uses curl if
wget is not present.  macOS ships with curl but not wget.

Tested on macOS and Lubuntu and Fedora Linux distributions.

Ok for trunk?

Damian


2017-04-05  Damian Rouson  <damian@sourceryinstitute.org>

        * download_prerequisites (md5_check): New function emulates Linux
        'md5 --check' on macOS.  Modified script for macOS compatibility.

I wonder if we should just switch to curl from wget in general ratherthan conditionalizing the code at all.

For the sums, rather than doing a check of the OS, just see ifsha512/md5sum exists. If not, then fallback to the Darwin defaults.


Jeff

Follow-Ups:
- Re: port contrib/download_prerequisites script to macOS
  - From: Martin Sebor

References:
- port contrib/download_prerequisites script to macOS
  - From: Damian Rouson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]