This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] simplify-rtx: Fix compare of comparisons (PR60818)
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 3 Apr 2017 12:19:40 -0500
- Subject: Re: [PATCH] simplify-rtx: Fix compare of comparisons (PR60818)
- Authentication-results: sourceware.org; auth=none
- References: <b4afa84705ef48a3d170ae269e8fb92b69053333.1490995891.git.segher@kernel.crashing.org> <31452abb-d456-ba6e-d53b-e443f968348e@redhat.com>
On Mon, Apr 03, 2017 at 11:01:23AM -0600, Jeff Law wrote:
> > PR rtl-optimization/60818
> > * simplify-rtx.c (simplify_binary_operation_1): Do not replace
> > a compare of comparisons with the thing compared if this results
> > in a different machine mode.
> >
> >gcc/testsuite/
> > PR rtl-optimization/60818
> > * gcc.c-torture/compile/pr60818.c: New testcase.
> Doesn't seem like a regression. But I can't see how it could possibly
> result in any correctness issues -- the absolute worst would be a
> performance issue and even that seems highly unlikely.
It ICEs with trunk, it didn't ICE with 6.
The problem is that changing the mode of the CC in the producer, while
not changing the mode in the consumer, is very wrong, and runs into
asserts later on.
> OK for the trunk if you think it's worth fixing for gcc-7. Else it's
> pre-approved for gcc-8.
I'll commit it then. Thanks,
Segher