This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Bump the default thread stack size on Darwin in libgomp (PR libgomp/79876)

From: Jeff Law <law at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>, Dominique d'Humières <dominiq at lps dot ens dot fr>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 3 Apr 2017 10:56:13 -0600
Subject: Re: [PATCH] Bump the default thread stack size on Darwin in libgomp (PR libgomp/79876)
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E17713D94F
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E17713D94F
References: <20170401122418.GU17461@tucnak>

On 04/01/2017 06:24 AM, Jakub Jelinek wrote:

Hi!

Apparently Darwin has insane default stack size for pthread_create
unless overridden through pthread_attr_setstacksize - 512kB, compared e.g.
to Linux usual default of around 8MB.  For typical OpenMP uses that is way
too low, so the following patch is an attempt to bump it to 2MB just on
Darwin, and on other targets keep the default.  Everything can be in any
case overridden through {,G}OMP_STACKSIZE env variables.

Bootstrapped/regtested on x86_64-linux and i686-linux, can anyone please test it
on darwin?

2017-04-01  Jakub Jelinek  <jakub@redhat.com>

	PR libgomp/79876
	* config/posix/thread-stacksize.h: New file.
	* config/darwin/thread-stacksize.h: New file.
	* config/nvptx/thread-stacksize.h: New file.
	* env.c: Include thread-stacksize.h.
	(initialize_env): Initialize stacksize to GOMP_DEFAULT_STACKSIZE
	instead of 0.  Call pthread_attr_setstacksize even if
	GOMP_DEFAULT_STACKSIZE is non-zero.

I've got a build started, but it's on an ancient macbook pro, so it'lltake a long time. Someone else with modern hardware could certainly getthis done faster :-)


jeff

Follow-Ups:
- Re: [PATCH] Bump the default thread stack size on Darwin in libgomp (PR libgomp/79876)
  - From: Jakub Jelinek

References:
- [PATCH] Bump the default thread stack size on Darwin in libgomp (PR libgomp/79876)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]