This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 7/9] ira-color

From: Jeff Law <law at redhat dot com>
To: Gerald Pfeifer <gerald at pfeifer dot com>, Andrew Jenner <andrew at codesourcery dot com>, Vladimir Makarov <vmakarov at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 3 Apr 2017 09:28:47 -0600
Subject: Re: [PATCH 7/9] ira-color
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B88F88E22C
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B88F88E22C
References: <e7b13ed0-f0eb-416a-6535-75b12612fe26@codesourcery.com> <alpine.LNX.2.21.1704011919300.3249@anthias.pfeifer.com>

On 04/01/2017 11:21 AM, Gerald Pfeifer wrote:

On Sat, 1 Apr 2017, Andrew Jenner wrote:

In the course of working with ia16, I found a case where the
sorted_allocnos
array in ira-color.c requires more than ira_allocnos_num entries. The
following patch allows this array to expand when this happens.

2017-04-01  Andrew Jenner  <andrew@codesourcery.com>

    * ira-color.c (n_sorted_allocnos): New variable.
    (improve_allocation): Use it.
    (ira_initiate_assign): Initialize it.
    (fast_allocation): Likewise.


General improvements/fixes like this you may want to submit independently
of your port and copy the respective maintainers (such as Vladimir for
register allocation who I'm adding now).

Right. ANd it would be helpful to have more information on how thishappened. Otherwise Vlad and the rest of the team have to guess whatmight have happened -- we might guess wrong leading to an incorrectconclusion about the correctness of the patch.


Testcases help considerably as well.

jeff

References:
- [PATCH 7/9] ira-color
  - From: Andrew Jenner
- Re: [PATCH 7/9] ira-color
  - From: Gerald Pfeifer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]