This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ICE on invalid with -Walloca-larger-than (PR tree-optimization/80109)

From: Jeff Law <law at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: Aldy Hernandez <aldyh at redhat dot com>, Martin Sebor <msebor at redhat dot com>
Date: Tue, 21 Mar 2017 09:40:57 -0600
Subject: Re: [PATCH] Fix ICE on invalid with -Walloca-larger-than (PR tree-optimization/80109)
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5ACE34DB14
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5ACE34DB14
References: <20170320185149.GK3172@redhat.com>

On 03/20/2017 12:51 PM, Marek Polacek wrote:

We crash with this invalid testcase because we aren't properly checking what we
are passing down to get_range_info, i.e., we can't pass a pointer.  So fixed by
checking the argument first, and calling alloca_type_and_limit if it is of a
wrong type.

Bootstrapped/regtested on x86_64-linux, ok for trunk?

2017-03-20  Marek Polacek  <polacek@redhat.com>
	    Martin Sebor  <msebor@redhat.com>

	PR tree-optimization/80109
	* gimple-ssa-warn-alloca.c (alloca_call_type): Only call get_range_info
	on INTEGRAL_TYPE_P.

	* gcc.dg/Walloca-14.c: New test.

OK.

jeff

References:
- [PATCH] Fix ICE on invalid with -Walloca-larger-than (PR tree-optimization/80109)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]