This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.

From: Toma Tabacu <Toma dot Tabacu at imgtec dot com>
To: "Catherine Moore (catherine_moore at mentor dot com)" <catherine_moore at mentor dot com>, Matthew Fortune <Matthew dot Fortune at imgtec dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Tue, 21 Mar 2017 11:09:17 +0000
Subject: RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.
Authentication-results: sourceware.org; auth=none
References: <A614194ED15B4844BC4C9FB7F21FCD9270457D3D@hhmail02.hh.imgtec.org> <6D39441BF12EF246A7ABCE6654B0235380BAFE76@hhmail02.hh.imgtec.org> <6233308df477450fb5cab0dd13dc9e61@SVR-ORW-MBX-04.mgc.mentorg.com>

> > From: Matthew Fortune
> >
> > I think the skip is OK here. I'd like to get Catherine's opinion on
> > this though too. I don't think we should change the definition of __PIC__
> > for -fPIC on MIPS as multi-got solves 'most' issues. If we start trying to
> > figure out what __PIC__ should mean on MIPS then we will get into a big
> > mess with -mxgot as that is arguably __PIC__==2 but I expect there will
> > be  several differing opinions.
> >
> From: Catherine Moore
>
> I think the skip is the right way to go as well.   The patch is OK with me.
> Catherine
> 

Committed as r246311.

Thanks,
Toma

References:
- [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.
  - From: Toma Tabacu
- RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.
  - From: Matthew Fortune
- RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.
  - From: Moore, Catherine

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]