This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] PR c++/35878
- From: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 21 Mar 2017 02:43:53 +0200
- Subject: Re: [C++ PATCH] PR c++/35878
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUbPyzFx-rozoCm5PRJ-fWW-VS4kF7o_0c7tVLcDCNpQsg@mail.gmail.com> <CADzB+2=1z-6GL1PNO+cST=KtrrLSmeGokjEzmQ89iu7fjh8Vcg@mail.gmail.com> <CAFk2RUaDq4ga1D-LcdOJzcn+UbF8m-YzeJRYpo3rULKtS=9qRw@mail.gmail.com> <alpine.DEB.2.20.1703210029490.1979@stedding.saclay.inria.fr> <CADzB+2nKVsz4KpwMkvEqkSAiHNCs9x33u69Jq=Hs4K1jbhEK3Q@mail.gmail.com> <CAFk2RUb84L5=Q9_DKnB9jSKw1+=FishTeaWU9x+s_9WChZoccQ@mail.gmail.com>
On 21 March 2017 at 02:36, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
> On 21 March 2017 at 01:44, Jason Merrill <jason@redhat.com> wrote:
>>> It looks strange to me. Why not change the definition of check_new instead
>>> of changing the condition that uses it?
>>
>> Agreed. Also, let's factor the new tests out into a function, say
>> non_allocating_fn_p.
>
> This also conveniently let's me provide a ChangeLog that reads like a
> Real Front-End
> Developer would've written it. :) New tests re-tested on Linux-x64,
> running full suite
> on Linux-PPC64.
Hmm. I should either rename that function or flip its logic. Now it's
a bit backwards. :) I'll flip its logic.