This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [ARM] Cleanup macro TARGET_EITHER
- From: "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, Sudi Das <Sudi dot Das at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- Date: Fri, 17 Mar 2017 13:11:20 +0000
- Subject: Re: [PATCH] [ARM] Cleanup macro TARGET_EITHER
- Authentication-results: sourceware.org; auth=none
- References: <VI1PR08MB0640EB037B2008CB88E87D2D98260@VI1PR08MB0640.eurprd08.prod.outlook.com> <58CBD4FD.20105@foss.arm.com>
On 17/03/17 12:22, Kyrill Tkachov wrote:
> Hi Sudi,
>
> On 16/03/17 11:11, Sudi Das wrote:
>>
>> Hi all
>>
>> This is a cleanup patch to remove the macro TARGET_EITHER. This macro
>> seems to have become irrelevant in recent times since its previous
>> definition had been commented out and replaced with 1.
>>
>> Bootstrapped and tested on arm-none-linux-gnueabihf.
>>
>
> I've had my eye on that cleanup for some time now, thanks for doing this.
> This patch is ok.
> Seeing as we're close to the GCC 7 release and this is not a regression fix
> I'd rather hold off applying it until after the release, so I've put
> this in
> my queue of things to commit then.
>
> Thanks,
> Kyrill
>
>> Sudi
>>
>> 2017-03-10 Sudakshina Das <sudi.das@arm.com>
>>
>> * config/arm/arm.h (TARGET_EITHER): Delete.
>> * config/arm/arm.md: Delete instances of TARGET_EITHER.
>
The point of TARGET_EITHER was mostly to document that the operation was
deliberately enabled in all compilation modes and that leaving out a
choice of TARGET32 vs Thumb1 was not accidental. As such, it's more
documentation than necessary code.
Does this really affect the performance/behaviour of the compiler? If
it doesn't then I'd be in favour of leaving it as is.
R.