This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING 6, PATCH] Remove xfail from thread_local-order2.C.
- From: Jiong Wang <jiong dot wang at foss dot arm dot com>
- To: Mike Stump <mikestump at comcast dot net>, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: Dominik Vogt <vogt at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 10 Mar 2017 16:22:50 +0000
- Subject: Re: [PING 6, PATCH] Remove xfail from thread_local-order2.C.
- Authentication-results: sourceware.org; auth=none
- References: <20160127093944.GA28942@linux.vnet.ibm.com> <20160620134121.GA27949@linux.vnet.ibm.com> <20170206102554.GA25206@linux.vnet.ibm.com> <alpine.LSU.2.20.1702061224500.2253@anthias.pfeifer.com> <yddzihza70e.fsf@CeBiTec.Uni-Bielefeld.DE> <C43EC866-CDC0-459C-A2BD-8515CE6341FA@comcast.net> <yddwpd28fqd.fsf@CeBiTec.Uni-Bielefeld.DE> <9924C96F-6C02-43BC-AF9C-FA8A2118B5B4@comcast.net>
On 07/02/17 16:01, Mike Stump wrote:
On Feb 7, 2017, at 2:20 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
No. In fact, I'd go for something like this:
2017-02-07 Dominik Vogt <vogt@linux.vnet.ibm.com>
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* g++.dg/tls/thread_local-order2.C: Only xfail execution on
*-*-solaris*.
# HG changeset patch
# Parent 031bb7a327cc984d387a8ae64e7c65d4b8793731
Only xfail g++.dg/tls/thread_local-order2.C on Solaris
diff --git a/gcc/testsuite/g++.dg/tls/thread_local-order2.C b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
--- a/gcc/testsuite/g++.dg/tls/thread_local-order2.C
+++ b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
@@ -2,10 +2,11 @@
// that isn't reverse order of construction. We need to move
// __cxa_thread_atexit into glibc to get this right.
-// { dg-do run { xfail *-*-* } }
+// { dg-do run }
// { dg-require-effective-target c++11 }
// { dg-add-options tls }
// { dg-require-effective-target tls_runtime }
+// { dg-xfail-run-if "" { *-*-solaris* } }
extern "C" void abort();
extern "C" int printf (const char *, ...);
This way one can easily add per-target PR references or explanations,
e.g. for darwin10 or others should they come up.
Tested on i386-pc-solaris2.12 and x86_64-pc-linux-gnu. Ok for mainline?
Ok.
I think that addresses most all known issues. I'll pre-appove any additional targets people find as trivial. For example, if darwin10 doesn't pass, then *-*-darwin10* would be fine to add if that fixes the issue. I don't happen to have one that old to just test on.
I am seeing this failure on arm and aarch64 bare-metal environment where newlib are used.
This patch also XFAIL this testcase on newlib.
OK for trunk?
Regards,
Jiong
gcc/testsuite/
2017-03-10 Jiong Wang <jiong.wang@arm.com>
* g++.dg/tls/thread_local-order2.C: XFAIL on newlib.
diff --git a/gcc/testsuite/g++.dg/tls/thread_local-order2.C b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
index 3cbd257b5fab05d9af7aeceb4f97e9a79d2a283e..d274e8c606542893f8a792469e075056793335ea 100644
--- a/gcc/testsuite/g++.dg/tls/thread_local-order2.C
+++ b/gcc/testsuite/g++.dg/tls/thread_local-order2.C
@@ -6,7 +6,7 @@
// { dg-require-effective-target c++11 }
// { dg-add-options tls }
// { dg-require-effective-target tls_runtime }
-// { dg-xfail-run-if "" { hppa*-*-hpux* *-*-solaris* } }
+// { dg-xfail-run-if "" { { hppa*-*-hpux* *-*-solaris* } || { newlib } } }
extern "C" void abort();
extern "C" int printf (const char *, ...);