This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/6] microblaze: Fixes for RTL checking

From: Michael Eager <eager at eagercon dot com>
To: Jakub Jelinek <jakub at redhat dot com>, Segher Boessenkool <segher at kernel dot crashing dot org>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 21 Feb 2017 12:35:17 -0800
Subject: Re: [PATCH 3/6] microblaze: Fixes for RTL checking
Authentication-results: sourceware.org; auth=none
References: <cover.1487685472.git.segher@kernel.crashing.org> <0b3332af5c3662c0efdf2d930c06457b0fd3cd13.1487685472.git.segher@kernel.crashing.org> <20170221201555.GW1849@tucnak>

On 02/21/2017 12:15 PM, Jakub Jelinek wrote:

On Tue, Feb 21, 2017 at 02:48:15PM +0000, Segher Boessenkool wrote:

-  /* Shift by zero -- copy regs if necessary.  */
+  /* Shift by zero -- copy regs.  */
    if ((GET_CODE (operands[2]) == CONST_INT) && (INTVAL (operands[2]) == 0))


You could have changed this line to
   if (operands[2] == const0_rtx)
as well.


And this would not change the generated code.

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Follow-Ups:
- Re: [PATCH 3/6] microblaze: Fixes for RTL checking
  - From: Jakub Jelinek
- Re: [PATCH 3/6] microblaze: Fixes for RTL checking
  - From: Segher Boessenkool

References:
- [PATCH 0/6] Fallout from RTL checking
  - From: Segher Boessenkool
- [PATCH 3/6] microblaze: Fixes for RTL checking
  - From: Segher Boessenkool
- Re: [PATCH 3/6] microblaze: Fixes for RTL checking
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]