This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][DOC][OBVIOUS] Document default value for use-after-scope-direct-emission-threshold


On 02/03/2017 10:45 AM, Gerald Pfeifer wrote:
> On Fri, 3 Feb 2017, Martin Liška wrote:
>> Installed as obvious as r245147.
> 
> Yes, but...

Hi.

Thanks for that, stupid typos.

> 
> I think you wanted to say "is 256", not "in 256" and make this a
> full sentence?  Looking at the entire entry I noticed a few other
> issues ("smaller of equal" instead of "smaller or equal", missing
> articles, passive voice,...) which I believe the patch below addresses.
> 
> (I'm still not quite sure what this option does, and whether we 
> could say "poison and unpoison it", for example?  Can you advise?)

I'm sending enhancement of that. Basically: direct poisoning = emitting
instructions that touch shadow memory vs. runtime callbacks = function
that does that :)

I welcome help with that.

Martin

> 
> Gerald
> 
> 2017-02-03  Gerald Pfeifer  <gerald@pfeifer.com>
> 
> 	* doc/invoke.texi (use-after-scope-direct-emission-threshold):
> 	Fix typos and grammar; use active voice.	
> 
> Index: doc/invoke.texi
> ===================================================================
> --- doc/invoke.texi	(revision 245148)
> +++ doc/invoke.texi	(working copy)
> @@ -10469,9 +10469,9 @@
>  @option{--param asan-instrumentation-with-call-threshold=0}.
>  
>  @item use-after-scope-direct-emission-threshold
> -If size of a local variables in bytes is smaller of equal to this number,
> -direct instruction emission is utilized to poison and unpoison local variables.
> -Default value in 256.
> +If the size of a local variable in bytes is smaller or equal to this number,
> +utilize direct instruction emission to poison and unpoison local variables.
> +The default value is 256.
>  
>  @item chkp-max-ctor-size
>  Static constructors generated by Pointer Bounds Checker may become very
> 

>From 685cf7e8e22380916ac2b020f03d517cc2ae3a9a Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Fri, 3 Feb 2017 12:29:35 +0100
Subject: [PATCH] v2

---
 gcc/doc/invoke.texi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 08d26a1d858..1dd26ad11c7 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -10469,9 +10469,9 @@ E.g. to disable inline code use
 @option{--param asan-instrumentation-with-call-threshold=0}.
 
 @item use-after-scope-direct-emission-threshold
-If size of a local variables in bytes is smaller of equal to this number,
-direct instruction emission is utilized to poison and unpoison local variables.
-Default value in 256.
+If size of a local variable in bytes is smaller or equal to this number,
+directly poison (or unpoison) shadow memory.  Otherwise runtime callbacks
+are used.  The default value is 256.
 
 @item chkp-max-ctor-size
 Static constructors generated by Pointer Bounds Checker may become very
-- 
2.11.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]