This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [wwwdocs, coding conventions] Mention OVERRIDE/FINAL
- From: Gerald Pfeifer <gerald at pfeifer dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, Bernd Schmidt <bschmidt at redhat dot com>, Jeff Law <law at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Trevor Saunders <tbsaunde at tbsaunde dot org>, gcc-patches at gcc dot gnu dot org, jit at gcc dot gnu dot org
- Date: Fri, 3 Feb 2017 09:34:52 +0100 (CET)
- Subject: Re: [wwwdocs, coding conventions] Mention OVERRIDE/FINAL
- Authentication-results: sourceware.org; auth=none
- References: <1462552846-17096-1-git-send-email-dmalcolm@redhat.com> <f0e254d6-6cb0-713b-884c-20b7bf80e605@redhat.com> <8ce94f18-421f-9466-85cf-e17d9caee151@redhat.com> <20160506183345.GK3628@ball> <5b2de202-c6bd-f8fc-3407-45a40ddfe62c@redhat.com> <b40ccecf-e327-c85c-c00f-20607f8fa115@redhat.com> <014f88ec-909b-db46-1213-e9dbb8f14ee4@redhat.com> <ec87abe2-fcd0-c85d-501c-366883bf7fe2@redhat.com> <0c78b409-efcc-3c49-4323-699e7ecfb6a0@redhat.com> <1476480483.10766.46.camel@redhat.com>
On Fri, 14 Oct 2016, David Malcolm wrote:
> On Fri, 2016-10-14 at 16:27 +0100, Pedro Alves wrote:
>> FYI, I pushed these in now. I also bootstrapped with the
>> jit included in the selected languages, and hacked the
>> jit code a bit to trigger the problems OVERRIDE intends to
>> catch, just to make sure it still works.
> I propose that we update our coding conventions to mention the OVERRIDE
> and FINAL macros in the paragraph that discusses virtual funcs.
>
> The attached patch (to the website) does so.
>
> OK to commit?
I noticed this one has neither been rejected nor applied.
The patch appears fine wearing my wwwdocs maintainer hat, alas I
do not feel confident approving it (content-wise).
Perhaps something for Jeff (now added) or Bernd?
Gerald
Index: htdocs/codingconventions.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v
retrieving revision 1.77
diff -u -p -r1.77 codingconventions.html
--- htdocs/codingconventions.html 18 Sep 2016 13:55:17 -0000 1.77
+++ htdocs/codingconventions.html 14 Oct 2016 21:22:44 -0000
@@ -902,7 +902,10 @@ Its use with data-carrying classes is mo
<p>
Think carefully about the size and performance impact
of virtual functions and virtual bases
-before using them.
+before using them. If you do use virtual functions, use the
+<code>OVERRIDE</code> and <code>FINAL</code> macros from
+<code>include/ansidecl.h</code> to annotate the code for a human reader,
+and to allow sufficiently modern C++ compilers to detect mistakes.
</p>
<p>