This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] IPA: enhance dump output


> 2017-01-24  Martin Liska  <mliska@suse.cz>
> 
> 	* cgraph.c (cgraph_node::dump): Dump function version info.
> 	* symtab.c (symtab_node::dump_base): Add missing new line.
> ---
>  gcc/cgraph.c | 10 ++++++++++
>  gcc/symtab.c |  1 +
>  2 files changed, 11 insertions(+)
> 
> diff --git a/gcc/cgraph.c b/gcc/cgraph.c
> index ef2dc50282c..74839f7d993 100644
> --- a/gcc/cgraph.c
> +++ b/gcc/cgraph.c
> @@ -2066,6 +2066,16 @@ cgraph_node::dump (FILE *f)
>      fprintf (f, "  Profile id: %i\n",
>  	     profile_id);
>    fprintf (f, "  First run: %i\n", tp_first_run);
> +  cgraph_function_version_info *vi = function_version ();
> +  if (vi != NULL)
> +    {
> +      /* Iterate to first item in the chain.  */
> +      while (vi->prev != NULL)
> +	vi = vi->prev;
> +      fprintf (f, "  Version info: ");
> +      dump_addr (f, "@", (void *)vi);
> +      fprintf (f, "\n");

I suppose it is useful to know that version info is attached, but instead of
dumping an address, i would rather meaningfully print its contents (i.e.
dispatcher and prev/next pointers in list).

OK with that change.

honza
> +    }
>    fprintf (f, "  Function flags:");
>    if (count)
>      fprintf (f, " executed %" PRId64"x",
> diff --git a/gcc/symtab.c b/gcc/symtab.c
> index 87febdc212f..0078896c8a8 100644
> --- a/gcc/symtab.c
> +++ b/gcc/symtab.c
> @@ -890,6 +890,7 @@ symtab_node::dump_base (FILE *f)
>      {
>        fprintf (f, "  Aux:");
>        dump_addr (f, " @", (void *)aux);
> +      fprintf (f, "\n");
>      }
>  
>    fprintf (f, "  References: ");
> -- 
> 2.11.0
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]