This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PGO bootstrap on x390x (PR bootstrap/78985).
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>
- Date: Wed, 1 Feb 2017 11:38:05 +0100
- Subject: Re: [PATCH] Fix PGO bootstrap on x390x (PR bootstrap/78985).
- Authentication-results: sourceware.org; auth=none
- References: <08fd2591-2e9b-7b62-aa85-f2ef57efa947@suse.cz> <7dc78fe5-73d2-ab2f-d0d5-19eeef0a0783@suse.cz> <8a0527de-4699-d3a9-bc32-afdbcf1c76c1@redhat.com> <49b023f5-0253-bc73-389f-6752b738792b@suse.cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 01, 2017 at 11:34:48AM +0100, Martin Liška wrote:
> > Presumably the issue with print_operand_address is that there are paths where s390_decompose_address can return without initializing AD/OUT. But AFAICT those are invalid addresses that presumably shouldn't be showing up in print_operand_address.
> >
> > Can you add an assert in print_operand_address to ensure decomposition never returns false?
Can't it happen e.g. with inline asm and "X" constraint?
output_operand_lossage then would emit an error rather than ICE for
something that is a user code bug, not internal compiler error.
>
> Like done in v2 of the patch?
>
> If so, I'll commit that.
Jakub