This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Avoid implicitly declared __mpxrt_stop in libmpx
- From: Alexander Ivchenko <mssakro at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Alexander Ivchenko <aivchenk at gmail dot com>, Ilya Enkovich <enkovich dot gnu at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 30 Jan 2017 14:21:30 +0300
- Subject: Re: [PATCH] Avoid implicitly declared __mpxrt_stop in libmpx
- Authentication-results: sourceware.org; auth=none
- References: <CACysShjZ8uMs3XCYA+-buXPS-ovYRs2jKfSeKStMrCD6hKLE+w@mail.gmail.com> <CAMbmDYak+iaz345yvmsLmYJAa5f=wieWCXFLb0Zd93rJc2Su4Q@mail.gmail.com> <CACysShjedT+KKWznvZBH7VnCiUAWU_Gh7wj=F7591Y8_h=a5Xw@mail.gmail.com> <CAMbmDYa_EmsNOpjcf=7+qqUCbAgORHTD1vpio_1e43yUiW1SUQ@mail.gmail.com> <CACysShgKwPchSFgo-L-Q2xO_Js1RZ_UE_NQ4scsZdjmnh+ctPQ@mail.gmail.com> <CAMbmDYbYxtB+3A3zZzJjGDj7g+8mgRX4seo0ZSiqAABFqkx1+w@mail.gmail.com> <CACysShi8sx4VQnx45U4isYmAEf5vW9cgJp02VwP3PQqdQTSi6g@mail.gmail.com> <20170130101314.GC13290@tucnak>
Hi Jakub,
Thanks for noticing that. Of course the declaration had to be in the
header for this case
Alexander
2017-01-30 13:13 GMT+03:00 Jakub Jelinek <jakub@redhat.com>:
> Hi!
>
> On Mon, Dec 26, 2016 at 06:15:01PM +0300, Alexander Ivchenko wrote:
>> Submitted as r243928.
>> >> (__mpxrt_stop): Ditto.
>
> I've noticed:
> ../../../../libmpx/mpxrt/mpxrt.c:255:6: warning: implicit declaration of function ‘__mpxrt_stop’; did you mean ‘__mpxrt_mode’? [-Wimplicit-function
> __mpxrt_stop ();
> ^~~~~~~~~~~~
> __mpxrt_mode
>
> The following patch fixes that warning, ok for trunk?
>
> 2017-01-30 Jakub Jelinek <jakub@redhat.com>
>
> * mpxrt/mpxrt-utils.h (__mpxrt_stop): New prototype.
>
> --- gcc/mpxrt/mpxrt-utils.h.jj 2016-12-27 15:35:06.000000000 +0100
> +++ gcc/mpxrt/mpxrt-utils.h 2017-01-30 10:31:51.502825561 +0100
> @@ -66,5 +66,6 @@ void __mpxrt_print (verbose_type vt, con
> mpx_rt_mode_t __mpxrt_mode (void);
> void __mpxrt_utils_free (void);
> void __mpxrt_print_summary (uint64_t num_brs, uint64_t l1_size);
> +void __mpxrt_stop (void) __attribute__ ((noreturn));
>
> #endif /* MPXRT_UTILS_H */
>
>
> Jakub
--
--Alexander