This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 5/5] add support for width and precision ranges (PR 78703)
- From: Markus Trippelsdorf <markus at trippelsdorf dot de>
- To: Martin Sebor <msebor at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 27 Jan 2017 08:44:57 +0100
- Subject: Re: [PATCH 5/5] add support for width and precision ranges (PR 78703)
- Authentication-results: sourceware.org; auth=none
- References: <fcf43443-f0b0-7da3-44ba-3fe3cc0dd96e@gmail.com>
On 2017.01.22 at 16:53 -0700, Martin Sebor wrote:
> This is the last patch in the series. It adds logic to handle
> non-constant width and precision with range information to help
> reduce both false positives false negatives. The patch replaces
> the scalar width and precision with two element arrays throughout
> the pass and makes adjustments to reflect their bounds in the byte
> counters. Since the basic infrastructure for this is present in
> the code the changes are fairly mechanical.
> commit c0a1f67fedb531abaf4760e8cd5b9b037ef5d4c4
> Author: Martin Sebor <msebor@redhat.com>
> Date: Sun Jan 22 12:37:33 2017 -0700
>
> 2017-01-22 Martin Sebor <msebor@redhat.com>
>
> * gimple-ssa-sprintf.c (adjust_for_width_or_precision): Change
> to accept adjustment as an array.
> (get_int_range): New function.
> (struct directive): Make width and prec arrays.
> (directive::set_width, directive::set_precision): Call get_int_range.
> (format_integer, format_floating): Handle width and precision ranges.
> (format_string, parse_directive): Same.
This is the third time that you broke bootstrap with MPFR 2.x.x:
gcc/gimple-ssa-sprintf.c:1501: error: 'MPFR_RNDN' was not declared in this scope
Please be more careful in the future.
--
Markus