This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix for entries in table of overloaded built-in functions
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: "Carl E. Love" <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Tue, 24 Jan 2017 14:43:38 -0600
- Subject: Re: [PATCH, rs6000] Fix for entries in table of overloaded built-in functions
- Authentication-results: sourceware.org; auth=none
- References: <1485275317.6275.98.camel@us.ibm.com> <20170124170835.GK30284@gate.crashing.org> <1485281363.6275.136.camel@us.ibm.com>
On Tue, Jan 24, 2017 at 10:09:23AM -0800, Carl E. Love wrote:
> > Do we need a separate testcase to check for this? Or do those specific
> > builtins need better testcases? Or was the bug obvious already?
[ ... ]
> Once the bug for the ALTIVEC_BUILTIN_VEC_PACKS built-in was found, I
> wrote a perl script to scan through the entire table looking for the
> issue with any other built-in functions.
I think we should have the compiler itself do this check, with flag_checking
enabled or similar. It is too easy to get this wrong it seems :-(
> Please let me know if you want me to go ahead with the adding the vec_packs() test cases
> to the patch or not. Again, not so sure about the vec_vgbbd test cases.
If you have tests ready, then sure, add them please (in a separate patch
is fine).
Segher