This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] BRIG frontend: request for a global review
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>, Pekka Jääskeläinen <pekka at parmance dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 23 Jan 2017 14:11:37 +0100
- Subject: Re: [PATCH] BRIG frontend: request for a global review
- Authentication-results: sourceware.org; auth=none
- References: <CAJk11WABrmm7q4ohe6uEDUeqiWRsa+HLw78VdRVqBqNnm6CrEg@mail.gmail.com> <CAJk11WCbs3JoFwFKHq=5g3Dq96_METRMHx4OHkajnzD6WGDysQ@mail.gmail.com> <CAFiYyc10E20yQiTORts82HdbB1FyuwKbLvqwnKnSZuTOXe8r1Q@mail.gmail.com> <CAJk11WAKHRzpuLx33qa_JBgGfbZOaOpg=wPS3H2rvAOaAUVy6A@mail.gmail.com> <CAFiYyc3Fjtca3gBsoOD_z8987=RHTMcWrQVMNWKvXZmT1xu_wA@mail.gmail.com> <20170116090746.GM1867@tucnak> <CAJk11WBNMcsLKkzX+GbovsDHq7mDQ0Ehxi_dBVcn9FjUCGY9eg@mail.gmail.com> <CAFiYyc2czhyGBqH5cRLX8otgGkDuJin_-bKsUq9vWaX003mNag@mail.gmail.com> <CAJk11WBpEyWmnSA9Nk3N48gnqwEecNYnNixeaLBX9Az4Hj=AAw@mail.gmail.com> <CAFiYyc1coXT531VGZ7R=2T8NjcVSGGK2Q4w6fmD5Xbpy-B=brA@mail.gmail.com> <20170123120240.h6kannl7ygryurbj@virgil.suse.cz>
On Mon, Jan 23, 2017 at 1:02 PM, Martin Jambor <mjambor@suse.cz> wrote:
> Hi,
>
>
> On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener wrote:
>> On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskeläinen <pekka@parmance.com> wrote:
>> > Hi Richard,
>> >
>> > On Fri, Jan 20, 2017 at 10:26 AM, Richard Biener
>> > <richard.guenther@gmail.com> wrote:
>> >> So the #ifdef ENABLE_BRIG_FE shouldn't be needed anymore (nor the
>> >> configury for it).
>> >>
>> >> Otherwise this looks ok to me then.
>> >
>> > Attached is a patch set with that unnecessary ENABLE_BRIG_FE macro
>> > removed. It has also been refreshed to the latest trunk.
>>
>> Are you set up to commit these to trunk yourself or do you need help here?
>>
>
> Pekka is still in the process of requesting an account at gcc.gnu.org.
> We agreed that I would commit the patches.
>
> Over Saturday and today morning, I have bootstrappet and tested them
> in various configurations (although mostly on x86_64 and only a little
> bit on aarch64) and (together with a "svn mv libgomp/plugin/hsa.h
> include/") I have not found any issue so far.
>
> I suppose I should go ahead (in any case, if there is any fallout,
> reach out to me too, at least until Pekka gets his account).
Yes, sounds good to me.
Richard.
> Thanks,
>
> Martin
>