This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3 PATCH] Make poisoned hashes SFINAE away the call operator of the hash.


On 20/01/17 17:50 +0200, Ville Voutilainen wrote:
On 20 January 2017 at 17:27, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
On 20 January 2017 at 17:21, Jonathan Wakely <jwakely@redhat.com> wrote:
This part for std::unique_ptr is the only part that isn't C++17-only,
so this is the part I'm most nervous about. Given that we're in stage
4 and this isn't even fixing something in Bugzilla (even if it is a
real bug), would it be possible to only fix optional and variant for
now? We could revisit the unique_ptr part once we know this approach
doesn't have some other problem that we haven't guessed yet.

Sure. I would guesstimate that custom pointer types that aren't
hashable should be rare,
so hitting that problem is unlikely.

I'll remove the unique_ptr bits, will give the deduced-bool a spin and
fix the whitespace, and will then
send a new patch for review.

Here:

OK for trunk - thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]