This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: coretypes.h: change class rtx_def to struct
- From: Richard Biener <rguenther at suse dot de>
- To: Gerald Pfeifer <gerald at pfeifer dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 19 Jan 2017 12:23:34 +0100 (CET)
- Subject: Re: coretypes.h: change class rtx_def to struct
- Authentication-results: sourceware.org; auth=none
- References: <alpine.LSU.2.20.1609281551010.2611@anthias.pfeifer.com>
On Thu, 19 Jan 2017, Gerald Pfeifer wrote:
> This innocent looking patch shaves 1749 warnings in stage 1
> when building with clang (such as on newer versions of FreeBSD).
>
> Richi, at one point you indicated such changes would be fine
> (though usually they go from struct to class)?
In this case I'd rather prefer you make rtx_def a class (for consistency
with the other classes deriving from it).
That change is ok.
Thanks,
Richard.
> Gerald
>
> 2016-09-28 Gerald Pfeifer <gerald@pfeifer.com>
>
> * coretypes.h (class rtx_def): Change to struct.
>
> Index: gcc/coretypes.h
> ===================================================================
> --- gcc/coretypes.h (revision 240576)
> +++ gcc/coretypes.h (working copy)
> @@ -59,7 +59,7 @@
> /* Subclasses of rtx_def, using indentation to show the class
> hierarchy, along with the relevant invariant.
> Where possible, keep this list in the same order as in rtl.def. */
> -class rtx_def;
> +struct rtx_def;
> class rtx_expr_list; /* GET_CODE (X) == EXPR_LIST */
> class rtx_insn_list; /* GET_CODE (X) == INSN_LIST */
> class rtx_sequence; /* GET_CODE (X) == SEQUENCE */
>
>
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)