This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3 PATCH] PR libstdc++/78389
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: Tim Song <t dot canens dot cpp at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 16 Jan 2017 11:24:46 +0000
- Subject: Re: [v3 PATCH] PR libstdc++/78389
- Authentication-results: sourceware.org; auth=none
- References: <CAFk2RUYjjXW2MGuEaLRPHV87R7YB-PTYhSk7QnxzJUBdHS4nkA@mail.gmail.com> <CAPQZVxvKSeaboXFC=W722L+M9W1fMW2v7Q3dZnfjfTYsxJmNhQ@mail.gmail.com> <CAFk2RUbWSEE9+573SJGiCUGQTHfG+EoLF8sEhk7PAsf5dQ=+0A@mail.gmail.com> <CAFk2RUYTg4BJGFnCQWYMGkBK6+KKtLETKMBKp+bS1-OuR2W1OA@mail.gmail.com>
On 15/01/17 19:07 +0200, Ville Voutilainen wrote:
PR libstdc++/78389
Fix backwards size adjustments.
I don't think repeating this text here and ...
* include/bits/list.tcc (merge(list&&)):
Fix backwards size adjustments.
... here is useful.
More useful would be a good Git-style commit log with a separate
description on the first line. So the svn commit would have a subject
line, followed by a blank line, followed by the content of the
ChangeLog entry e.g.
PR78389 fix backwards size adjustments
PR libstdc++/78389
* include/bits/list.tcc (merge(list&&)): Fix backwards size
adjustments.
(merge(list&&, _StrictWeakOrdering)): Likewise.
* testsuite/23_containers/list/operations/78389.cc: Add
better test for the sizes.
See the output of "git log --pretty=oneline --abbrev-commit" for why
that's useful (and how messy and unhelpful that output is when commits
don't have a separate summary on the first line). See also
http://chris.beams.io/posts/git-commit/
Anyway ...
OK for trunk with the additional changes to use better magic numbers
in the tests.