This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libgo patch committed: Update to Go1.8rc1
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Ian Lance Taylor <iant at golang dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "gofrontend-dev\@googlegroups.com" <gofrontend-dev at googlegroups dot com>
- Date: Sun, 15 Jan 2017 19:08:10 +0100
- Subject: Re: libgo patch committed: Update to Go1.8rc1
- Authentication-results: sourceware.org; auth=none
- References: <CAOyqgcXSYh2Yh9RtyuJp4JJPtrQESNZr5WaRXoVUk42koKtpWw@mail.gmail.com> <878tqco9uv.fsf@linux-m68k.org>
Andreas Schwab <schwab@linux-m68k.org> writes:
> In file included from ../../../libgo/runtime/runtime.h:113:0,
> from ../../../libgo/runtime/go-libmain.c:15:
> ./runtime.inc:650:8: error: redefinition of 'struct siginfo'
> struct siginfo {
> ^~~~~~~
> In file included from /usr/include/signal.h:79:0,
> from ../../../libgo/runtime/runtime.h:9,
> from ../../../libgo/runtime/go-libmain.c:15:
> /usr/include/bits/siginfo.h:46:16: note: originally defined here
> typedef struct siginfo
> ^~~~~~~
> In file included from ../../../libgo/runtime/runtime.h:113:0,
> from ../../../libgo/runtime/go-main.c:17:
> ./runtime.inc:650:8: error: redefinition of 'struct siginfo'
> struct siginfo {
> ^~~~~~~
> In file included from /usr/include/signal.h:79:0,
> from ../../../libgo/runtime/runtime.h:9,
> from ../../../libgo/runtime/go-main.c:17:
> /usr/include/bits/siginfo.h:46:16: note: originally defined here
> typedef struct siginfo
> ^~~~~~~
> In file included from ../../../libgo/runtime/runtime.h:113:0,
> from ../../../libgo/runtime/aeshash.c:7:
> ./runtime.inc:650:8: error: redefinition of 'struct siginfo'
> struct siginfo {
> ^~~~~~~
> In file included from /usr/include/signal.h:79:0,
> from ../../../libgo/runtime/runtime.h:9,
> from ../../../libgo/runtime/aeshash.c:7:
> /usr/include/bits/siginfo.h:46:16: note: originally defined here
> typedef struct siginfo
> ^~~~~~~
> make[4]: *** [libgobegin_a-go-main.o] Error 1
Same on Solaris. However, before I even get there, I hit
make[4]: *** No rule to make target 'golang_org/x/net/lif/lif.lo', needed by 'libgo.la'. Stop.
Fixed like this:
diff --git a/libgo/Makefile.am b/libgo/Makefile.am
--- a/libgo/Makefile.am
+++ b/libgo/Makefile.am
@@ -1133,7 +1133,7 @@ if LIBGO_IS_BSD
$(eval $(call PACKAGE_template,golang_org/x/net/route))
golang_org_x_net_route_lo = \
- golang_org/x/net/route/route.lo
+ golang_org/x/net/route.lo
golang_org_x_net_route_check = \
golang_org/x/net/route/check
@@ -1146,7 +1146,7 @@ if LIBGO_IS_SOLARIS
$(eval $(call PACKAGE_template,golang_org/x/net/lif))
golang_org_x_net_lif_lo = \
- golang_org/x/net/lif/lif.lo
+ golang_org/x/net/lif.lo
golang_org_x_net_lif_check = \
golang_org/x/net/lif/check
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University