This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH, i386] Improve and fix ix86_target_string debugging, add missing opts (and fix -msgx option)


Hello!

Attached patch significantly improves ix86_target_string_debugging:

- displays missing options in isa2 bitmpap
- adds missing options (also to the testcase)
- renames internal variables to more sensible names
- fixes comment about option order
- orders options to what the comment really describes
- synchronizes new order between
  * ix86_target_string
  * ix86_valid_target_attribute_inner_p
  * funcspec testcases

These changes allowed me to debug and finally fix wrong variable for
-msgx option mask.

2017-01-13  Uros Bizjak  <ubizjak@gmail.com>

    * config/i386/i386.opt (msgx): Use ix86_isa_flags2 variable.
    * config/i386/i386.c (ix86_target_string): Add missing options
    to isa_opts and reorder options by implied ISAs.  Rename isa_opts2 to
    isa2_opts, ix86_flag_opts to flag2_opts, ix86_target_other to
    flags_other and ix86_target_other to flags2_other.  Display unknown
    isa2 options.
    (ix86_valid_target_attribute_inner_p): Add missing options and
    reorder options by implied ISAs, as in ix86_target_string.

    testsuite/ChangeLog:

2017-01-13  Uros Bizjak  <ubizjak@gmail.com>

    * gcc.target/i386/funcspec-56.inc: Add missing options and
    reorder options by implied ISAs, as in ix86_target_string.

Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

Committed to mainline SVN.

Uros.

Attachment: p.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]