This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH TEST]Add test for PR78652

From: "Bin.Cheng" <amker dot cheng at gmail dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Jeff Law <law at redhat dot com>, Bin Cheng <Bin dot Cheng at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
Date: Fri, 13 Jan 2017 15:48:02 +0000
Subject: Re: [PATCH TEST]Add test for PR78652
Authentication-results: sourceware.org; auth=none
References: <VI1PR0802MB217647BE26854962AEF2F9FFE7870@VI1PR0802MB2176.eurprd08.prod.outlook.com> <8ed0a7b9-0920-b626-7705-a4a792553108@redhat.com> <20161212163541.GA3541@tucnak.redhat.com>

On Mon, Dec 12, 2016 at 4:35 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Mon, Dec 12, 2016 at 09:32:30AM -0700, Jeff Law wrote:
>> On 12/09/2016 03:20 AM, Bin Cheng wrote:
>> >Hi,
>> >PR78652 was fixed by patch for PR77856, this patch adds a test for it.  Test result checked, is it OK?
>> >
>> >Thanks,
>> >bin
>> >
>> >gcc/testsuite/ChangeLog
>> >2016-12-07  Bin Cheng  <bin.cheng@arm.com>
>> >
>> >     PR rtl-optimization/78652
>> >     * gcc.c-torture/execute/pr78652.c: New test.
>> >
>> You need to restrict it to targets with named section support -- or --
>> remove the attribute section from main.
>>
>> /* { dg-require-effective-target named_sections } */
>
> If the testcase fails before r243038 without the attribute and succeeds
> with it, I'd strongly prefer the latter option - remove the attribute.
Hi,
Thank you both for reviewing, the attribute is irrelevant to test, so
this version has it removed.

Thanks,
bin
>
>         Jakub

Attachment: pr78652.txt
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]