This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed fixincludes patch
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Bruce Korb <bkorb at gnu dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 13 Jan 2017 14:17:22 +0100
- Subject: Re: Unreviewed fixincludes patch
- Authentication-results: sourceware.org; auth=none
- References: <ydd37goa9np.fsf@CeBiTec.Uni-Bielefeld.DE> <CAKRnqNJZQuDq3kYVqaC=dEV9pNdOKSnEhJP7TUkGysCw1EEshg@mail.gmail.com>
Hi Bruce,
> *I* would certainly argue that. I do occasionally shut down the
> internet and go on vacation :). Looks good to me, not being a Solaris
good habit: should get into it myself ;-)
> person anymore.
Thanks.
> BTW, tiny notational/formatting thing: the '<<-' "here text" marker says to
> strip leading tabs on each line. In other words, the following can be indented
> with tabs to be more eyeball friendly (for future reference):
>
>
> +fix = {
> + hackname = solaris_gets_cxx14;
> + mach = "*-*-solaris2*";
> + files = "iso/stdio_iso.h";
> + select = <<- _EOSelect_
> +(#if __STDC_VERSION__ < 201112L)
> +(extern char \*gets\(char \*\) __ATTR_DEPRECATED;)
> +_EOSelect_;
> + c_fix = format;
> + c_fix_arg = "%1 && __cplusplus < 201402L\n%2";
Great, I'll try to remember that.
In the meantime, I've tested the fix on the gcc-5 and gcc-6 branches,
too: it didn't need more than regenerating fixincl.x and fixed the
failing testcase as expected.
I'll wait a week or two on mainline and apply it to the those branches,
too.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University