This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed fixincludes patch
- From: Bruce Korb <bkorb at gnu dot org>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 12 Jan 2017 11:45:00 -0800
- Subject: Re: Unreviewed fixincludes patch
- Authentication-results: sourceware.org; auth=none
- References: <ydd37goa9np.fsf@CeBiTec.Uni-Bielefeld.DE>
*I* would certainly argue that. I do occasionally shut down the
internet and go on vacation :). Looks good to me, not being a Solaris
person anymore.
BTW, tiny notational/formatting thing: the '<<-' "here text" marker says to
strip leading tabs on each line. In other words, the following can be indented
with tabs to be more eyeball friendly (for future reference):
+fix = {
+ hackname = solaris_gets_cxx14;
+ mach = "*-*-solaris2*";
+ files = "iso/stdio_iso.h";
+ select = <<- _EOSelect_
+(#if __STDC_VERSION__ < 201112L)
+(extern char \*gets\(char \*\) __ATTR_DEPRECATED;)
+_EOSelect_;
+ c_fix = format;
+ c_fix_arg = "%1 && __cplusplus < 201402L\n%2";