This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts
- From: Chung-Lin Tang <chunglin_tang at mentor dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 12 Jan 2017 19:59:41 +0800
- Subject: Re: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts
- Authentication-results: sourceware.org; auth=none
- References: <87a13495-a378-b5e1-8223-0f5679f98356@mentor.com> <20161111103441.GY3541@tucnak.redhat.com> <cbe5aca8-77c5-0057-1381-4a99e43b4318@codesourcery.com> <20161118112451.GW3541@tucnak.redhat.com> <7467e478-cee5-b694-2988-e6887f25fa17@codesourcery.com> <f3eecbe4-2641-44a2-af52-c7bcb082ab75@mentor.com>
[ping]
Hi Jakub,
I don't think we ever got approval for the Fortran parts of the OpenACC tile patch?
Is this okay for trunk? I'll be committing all parts of the patch once the Fortran
parts are approved.
Thanks,
Chung-Lin
On 2016/12/14 04:37 PM, Chung-Lin Tang wrote:
> On 2016/11/30 10:47 AM, Cesar Philippidis wrote:
>> On 11/18/2016 03:24 AM, Jakub Jelinek wrote:
>>> On Sat, Nov 12, 2016 at 08:51:00AM -0800, Cesar Philippidis wrote:
>>>> On 11/11/2016 02:34 AM, Jakub Jelinek wrote:
>>>>> On Thu, Nov 10, 2016 at 06:46:46PM +0800, Chung-Lin Tang wrote:
>>>>
>>>> And here's the patch.
>>>
>>> The patch doesn't look like OpenACC tile clause fortran support,
>>> but bind/nohost clause C/C++ support.
>>
>> I think I got that patch mixed up with the acc routines patch. Here is
>> the fortran tile clause patch.
>>
>> One notable difference between the trunk and gomp4 implementation of the
>> tile clause is that gomp4 errors on negative value tile arguments,
>> whereas trunk issues warnings. Is there a reason why the fortran FE
>> generally emits a warning, on say num_threads(-5), instead of an error?
>>
>> Chung-Lin, I noticed in your source tree that you included a change to
>> gfortranspec.c. Is that necessary for trunk? I've included in this patch
>> just in case the other tile patches require it.
>>
>> Cesar
>>
>
> About the gfortranspec.c change, that's just a testing artifact, not part of the Fortran FE patch.
>
> Chung-Lin
>